fix(react): popover caret is not hidden when caret prop is false #15232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…aret-prop-is-false
…aret-prop-is-false
alisonjoseph
requested changes
Nov 29, 2023
There was a problem hiding this comment.
Thanks for the PR, however I think this can be accomplished by simply adding more specificity to the scss, without needing to update anything else. The caret is already set to display:none by default, it just needs the specificity to only display when the parent --caret class is visible, and the code is already correctly setting that classname.
|
Hi @alisonjoseph! I made a little change on README since I contributed to docs in other PR. |
alisonjoseph
approved these changes
Dec 4, 2023
…aret-prop-is-false
andreancardona
approved these changes
Dec 5, 2023
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Dec 5, 2023
451ce65
21 checks passed
kuri-sun
deleted the
fix/react/Popover-caret-is-not-hidden-when-caret-prop-is-false
branch
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
…bon-design-system#15232) * fix(react): popover caret is not hidden when caret prop is false * fix(react): popover caret is not hidden when caret prop is false --------- Co-authored-by: Andrea N. Cardona <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15155
Popover caret is not hidden when caret prop is false.
Changelog
New
caretprop to the PopoverContent component to make the caret HTML element visible/invisible.${prefix}--popover-caret-closeto the PopoverContent component only whencaretistrue.${prefix}--popover-caret-closeclass.Changed
caretin the PopoverContent component inPublicAPI-test.js.snapfor testing.Additional
Testing / Reviewing
(Cause)
Because
caretprop does not get passed down to PopoverContent which contains the actual caret HTML element.The PopoverContent component needs to know whether
caretprop istrueorfalseto make the caret HTML element visible/invisible.PopoverContent is used by Popover, DefinitionTooltip, and Tooltip components.
(Solution)
By adding
caretprop to the PopoverContent component, the PopoverContent has control over the actual HTML element to be hidden/shown.