Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: paginationNav support high page counts #15219

Merged
merged 10 commits into from
Dec 11, 2023
Merged

feat: paginationNav support high page counts #15219

merged 10 commits into from
Dec 11, 2023

Conversation

kSee04
Copy link
Contributor

@kSee04 kSee04 commented Nov 16, 2023 •
edited
Loading

This commit updates PaginationNav to support high page counts. I add a prop to PaginationNav which short circuits logic causing present issue

Closes #15014

Changelog

New

  • Added new prop disableOverflow which fixes the problem elaborated on in the issue.
  • Added storybook example named "Overflow Disabled"

Changed

  • Storybook playground for PaginationNav has been changed to include the new disableOverflow prop

Removed

  • Nothing removed

Testing / Reviewing

@kSee04
feat: paginationNav support high page counts
16030d8 
This commit updates PaginationNav to support high page counts.
I add a prop to PaginationNav which short circuits logic causing present issue
@kSee04 kSee04 requested review from a team as code owners November 16, 2023 18:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@kSee04
Copy link
Contributor Author

kSee04 commented Nov 16, 2023

I have read the DCO document and I hereby sign the DCO.

@kSee04
Copy link
Contributor Author

kSee04 commented Nov 16, 2023

recheck

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 16030d8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65565d46cfe43e00087e5c3c
😎 Deploy Preview https://deploy-preview-15219--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bc11719
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65565da25759b800089977b6
😎 Deploy Preview https://deploy-preview-15219--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 1748e9c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6577236c08a32e0009b7ac4b
😎 Deploy Preview https://deploy-preview-15219--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tay1orjones
tay1orjones reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally the ... would no longer be interactive and removed from the focus order, rather than a select without any options. As is, I think it would read oddly with screenreaders.

Could we just put disabled on the select and also not render any items into the select?

@mbgower do you have any thoughts on what an ideal approach could be here? I'm not sure if we'd want the ellipsis to be focusable (and read) or not, and if disabled would be enough.

@kSee04
Copy link
Contributor Author

kSee04 commented Nov 16, 2023

@tay1orjones Thanks for quick review! I've made those requested changes.

@kSee04 kSee04 requested a review from tay1orjones November 16, 2023 20:08
alisonjoseph
alisonjoseph approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I'm not sure we need to keep the new "Overflow Disabled" story you added, I think having the prop in the playground is probably enough. thoughts @tay1orjones

tay1orjones
tay1orjones approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I just updated the PR to remove the test story. Thanks again!

@github-actions github-actions bot enabled auto-merge December 11, 2023 14:58
@github-actions github-actions bot added this pull request to the merge queue Dec 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 11, 2023
@tay1orjones tay1orjones merged commit 4d278de into carbon-design-system:main Dec 11, 2023
21 checks passed
danoro96 pushed a commit to danoro96/carbon that referenced this pull request Jan 18, 2024
@kSee04 @alisonjoseph
@andreancardona @tay1orjones @danoro96
feat: paginationNav support high page counts (carbon-design-system#15219
b2c0910 
)

* feat: paginationNav support high page counts

This commit updates PaginationNav to support high page counts.
I add a prop to PaginationNav which short circuits logic causing present issue

* Update README.md

* fix: code review

* docs(paginationnav): remove test story

---------

Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: Andrea N. Cardona <[email protected]>
Co-authored-by: Taylor Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add disableOverflow option to PaginationNav to support high page counts
4 participants
@kSee04 @alisonjoseph @tay1orjones @andreancardona