Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(text-area): support contextual layout tokens (density) #14697

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

janhassel
Copy link
Member

Ref #13923

Adds support for contextual layout tokens to TextArea.
Supported groups: density.

Changelog

Changed

  • Updated TextArea styles to support density group

Testing / Reviewing

Locally run storybook

  • padding-inline should adapt to layout.density
  • position of invalid icon should adapt to layout.density

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6b883f6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/650d5ea7899d5f0008478c50
😎 Deploy Preview https://deploy-preview-14697--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6b883f6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/650d5ea7e8070d0008b50e23
😎 Deploy Preview https://deploy-preview-14697--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Jan! 🏆

@tay1orjones tay1orjones added this pull request to the merge queue Sep 27, 2023
Merged via the queue into carbon-design-system:main with commit 9c53ea5 Sep 27, 2023
@janhassel janhassel deleted the 13923-text-area branch September 29, 2023 07:22
@carbon-automation
Copy link
Contributor

Hey there! v11.39.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants