-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@carbon/styles): change rem
function to to-rem
#14420
fix(@carbon/styles): change rem
function to to-rem
#14420
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add some sassdoc comments where the rem
function is declared, and then regenerate the sassdocs for the styles package? It might also be helpful if that comment lists the error message directly so searching the error returns those comments talking about how we have to use a namespace on rem()
Just trying to think about how we could try to prevent folks from asking about this in support, etc.
Thanks, I hope this will be backport to v10 as well since the first ref issue is created for v10 |
@nelsonchen90 yeah, we'll definitely get it backported as well since this will affect all users |
rem
function to to-rem
Refs #14415
Refs sass/dart-sass#2059
Namespaces all
rem
functions toconvert.to-rem
used across the repo.Also, bumpsWe'll bump this once the v10 fix is made so we can updatesass
to the latest versionincremental-migration
example.This version bump was causing issues due to the change withrem
upstream expecting two parameters https://github.com/sass/dart-sass/releases/tag/1.65.0Changelog
Changed
rem
function changed toto-rem
@use './utilities/convert' as *;
to@use './utilities/convert';
rem(
have been changed toconvert.to-rem(
Testing / Reviewing
Ensure there are no visual changes and all sass files compile successfully.