Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): breadcrumbs export file .js to .ts #14398

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix(typescript): breadcrumbs export file .js to .ts #14398

merged 1 commit into from
Aug 16, 2023

Conversation

Husnain062
Copy link
Contributor

Changed

  • Rename Breadcrumbs export file index.js files to index.ts.

@Husnain062 Husnain062 requested a review from a team as a code owner August 4, 2023 21:53
@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0e1d9d6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64d105998270cb0008e055d8
😎 Deploy Preview https://deploy-preview-14398--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0e1d9d6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64d105990a954500087af01e
😎 Deploy Preview https://deploy-preview-14398--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Husnain062 Husnain062 force-pushed the breadcrumbs-export-file-to-ts branch from 1a57b11 to 0e1d9d6 Compare August 7, 2023 14:54
andreancardona
andreancardona approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! @Husnain062

@github-actions github-actions bot added this pull request to the merge queue Aug 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 9, 2023
@github-actions github-actions bot added this pull request to the merge queue Aug 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 15, 2023
@tay1orjones tay1orjones added this pull request to the merge queue Aug 16, 2023
Merged via the queue into carbon-design-system:main with commit 3f80dee Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph

Assignees
No one assigned
Labels
status: one more review 👀 status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Husnain062 @alisonjoseph @tay1orjones @tw15egan @andreancardona