fix(Button): Align Ghost Button Kind hover & active styles with Design Guidance #14394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
requested review from
a team and
aubrey-oneal
and removed request for
a team
alisonjoseph
approved these changes
Aug 4, 2023
laurenmrice
approved these changes
Aug 10, 2023
tw15egan
pushed a commit
to conradennis/carbon
that referenced
this pull request
Aug 10, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
* feat(icons): new delete and return icons Submitting 2 new UI icons per Thy's request. These will be implemented in a new Carbon component. All additions approved by BXD 2 net new icons updated categories.yml with additions Changelog Net New – 32/delete.svg – 32/return.svg * chore(icons): update snapshots * fix(Button): ghost hover/active styles (#14394) * chore(icons): update snapshots pt 2 --------- Co-authored-by: TJ Egan <[email protected]> Co-authored-by: Steven Black <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Design guidance specifications for Ghost Button:
Changelog
Changed
$layer-hover->$background-hover$layer-active->$background-activeTesting / Reviewing
layertokensbackgroundtokens👍