Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): ensure Select properly truncates long strings #14356

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

tw15egan
Copy link
Collaborator

Closes #14343

Adds in styles to truncate long Select strings. It also adds some logic to automatically generate a title attribute, which matches the behavior for Dropdown, Combobox, and other Listbox elements.

Changelog

New

  • Styles to add ellipsis when text is too long
  • Populate the title field with the currently selected item

Changed

  • Changed the storybook SelectedItem values to more human-readable values.
  • Added a long string to test truncation

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit bbcc479
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64c82f6d3b49f600082d894b
😎 Deploy Preview https://deploy-preview-14356--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bbcc479
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64c82f6d3c02fa0007ed6fdf
😎 Deploy Preview https://deploy-preview-14356--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added this pull request to the merge queue Aug 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 2, 2023
@tw15egan tw15egan added this pull request to the merge queue Aug 2, 2023
Merged via the queue into carbon-design-system:main with commit d533d50 Aug 2, 2023
@tw15egan tw15egan deleted the select-overflow branch August 2, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: String is truncated when a Select item is too long
3 participants