fix(Button): ensure onMouseEnter fires when moving from disabled button #13925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
guidari
approved these changes
Jun 6, 2023
andreancardona
approved these changes
Jun 6, 2023
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
DO NOT MERGE
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13815
Adds in a workaround to ensure that
onMouseEnterfires when the mouse cursor enters the button from abuttonin adisabledstate. I've wrapped theButtonin a wrapperdivwhich setscursor: not-allowedto mimic the cursor of adisabledbutton, and then setpointer-events: noneon the underlying button.Changelog
New
disabledis defined as aPropTypeofIconButtonso that we can set a proper wrapper class to target via cssPopovertrigger is now wrapper in adiv.cds--tooltip-trigger__wrapperTesting / Reviewing
Go to
Button --> Teststory and hover from the firstdisabledbutton to the enabled button and you should see the Tooltip appear. Compare to here: https://codesandbox.io/s/nifty-bassi-bkwmng?file=/src/index.jsWill remove the story before merging