fix: replace hard coded bx prefix with variable #1381
Conversation
alisonjoseph
changed the title
| @@ -11,7 +11,7 @@ | |||
| @import '../list-box/list-box'; | |||
|
|
|||
| @include exports('combo-box') { | |||
| .bx--combo-box > .bx--list-box__field { | |||
| .#{$prefix}--combo-box > .#{$prefix}--list-box__field { | |||
There was a problem hiding this comment.
Somewhat related to your PR, but I noticed that ComboBox has an extra box-shadow that could be bundled in with these changes
There was a problem hiding this comment.
Looks like there is box shadow and also the border-bottom on the input inside the list box? 🤔
| @@ -13,11 +13,11 @@ | |||
| @import '../list-box/list-box'; | |||
|
|
|||
| @include exports('multi-select') { | |||
| .bx--multi-select.bx--combo-box > .bx--list-box__field { | |||
| .#{$prefix}--multi-select.#{$prefix}--combo-box > .#{$prefix}--list-box__field { | |||
There was a problem hiding this comment.
I'm also noticing that box-shadow here, but it looks like we never added the gray-50 border bottom. Perhaps this is a bigger change than I thought
There was a problem hiding this comment.
Might be better in a separate issue around list box styles, there is a lot going on here 🙃
There was a problem hiding this comment.
Yeah, I'll work on that this morning and fix that up. Disregard!
| @@ -145,7 +145,7 @@ | |||
| } | |||
|
|
|||
| .#{$prefix}--overflow-menu-options__option--danger { | |||
| .bx--overflow-menu-options__btn { | |||
| .#{$prefix}--overflow-menu-options__btn { | |||
There was a problem hiding this comment.
I'm not sure if this has always been the case, but the overflow-menu doesn't show up in experimental mode
There was a problem hiding this comment.
Looks like this is related to product switcher? We can fix this when we build out the experimental overflow menu.
There was a problem hiding this comment.
Yeah I can work on that one next week and get it figured out 👍
|
🎉 This PR is included in version 9.43.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…arbon-design-system#1381) * fix(Components): add initial state and remove empty state validation * fix(Components): revert Tooltip.js changes * fix(Components): set initial selected in TileGroup component
Noticed some hard coded
.bx--classnames. Did a find on the entire project and replaced them with#{$prefix}--