Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): add aria-labelledby to tooltip #1378

Merged
merged 2 commits into from
Nov 2, 2018
Merged

fix(tooltip): add aria-labelledby to tooltip #1378

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce4833
fix(tooltip): add aria-labelledby to tooltip
dakahn Nov 2, 2018
e5e5798
Merge branch 'master' into 1367-tooltip-avt1
alisonjoseph Nov 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/tooltip/tooltip.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="bx--tooltip__label" aria-describedby="unique-tooltip">
<div id="tooltip-label" class="bx--tooltip__label" aria-describedby="unique-tooltip">
Tooltip label
<div tabindex="0" data-tooltip-trigger data-tooltip-target="#unique-tooltip" role="tooltip" class="bx--tooltip__trigger">
<div tabindex="0" aria-labelledby="tooltip-label" data-tooltip-trigger data-tooltip-target="#unique-tooltip" role="tooltip" class="bx--tooltip__trigger">
<svg width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
<g fill-rule="evenodd">
<path d="M8 14.5a6.5 6.5 0 1 0 0-13 6.5 6.5 0 0 0 0 13zM8 16A8 8 0 1 1 8 0a8 8 0 0 1 0 16z" fill-rule="nonzero" />
Expand Down