Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/HeaderNavigation types #13762

Merged

Conversation

mrkjdy
Copy link
Contributor

@mrkjdy mrkjdy commented May 8, 2023

Closes #13593

Converted UIShell/HeaderNavigation.js to tsx and added appropriate prop types.

Changelog

New

  • Added type for HeaderNavigation props

Changed

  • Renamed UIShell/HeaderNavigation.js to UIShell/HeaderNavigation.tsx
  • Removed a duplicate export of HeaderNavigation that was only used in one place

Testing / Reviewing

You can check this by confirming that there are no errors when:

  • building
  • viewing the UIShell stories that have a HeaderNavigation
  • creating a component that uses the HeaderNavigation and testing which props are valid/invalid

@mrkjdy mrkjdy requested a review from a team as a code owner May 8, 2023 17:44
@mrkjdy mrkjdy requested review from alisonjoseph and tw15egan May 8, 2023 17:44
@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 257f054
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64593bf3e99d98000862313f
😎 Deploy Preview https://deploy-preview-13762--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 257f054
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64593bf361e63a00095fa07e
😎 Deploy Preview https://deploy-preview-13762--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 54404fc into carbon-design-system:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to HeaderNavigation
3 participants