feat(Table): add typescript type annotations to Table
#13372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
tay1orjones
approved these changes
Mar 21, 2023
aze3ma
requested review from
tay1orjones
and removed request for
tw15egan and
andreancardona
tay1orjones
approved these changes
Mar 22, 2023
tay1orjones
reviewed
Mar 22, 2023
packages/react/src/components/DataTable/__tests__/exports-test.js
Outdated
Show resolved
Hide resolved
francinelucca
requested changes
Mar 23, 2023
aze3ma
requested review from
francinelucca and
tay1orjones
and removed request for
francinelucca and
tay1orjones
francinelucca
requested changes
Mar 23, 2023
Co-authored-by: Francine Lucca <[email protected]>
francinelucca
approved these changes
Mar 23, 2023
francinelucca
added
status: ready to merge 🎉
and removed
status: failing CI 🙅♂️
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12517
Convert existing propType definitions to
typescriptannotations on theTablecomponent.This is part of a broader effort to add Typescript annotations to components, that is originally tracked in #12517.
Changelog
New
typescripttype annotations forTabletypescripttype annotations forTableContext(due toTabledepending on it).Changed
packages/react/src/components/DataTable/Table.jstopackages/react/src/components/DataTable/Table.tsxpackages/react/src/components/DataTable/TableContext.jstopackages/react/src/components/DataTable/TableContext.tsRemoved
N/ATesting / Reviewing
yarn buildsuccessfully inpackages/reactand runningyarn storybookchecks that inside theDataTableeverything is renders correctly without any errors.