Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MultiSelect): remove enter key select #13362

Merged
merged 13 commits into from
Mar 21, 2023
Merged

fix(MultiSelect): remove enter key select #13362

merged 13 commits into from
Mar 21, 2023

Conversation

pratikkarad
Copy link
Contributor

Closes #13119

Removed

  • Removed additional Enter key from MultiSelect keyboard selection

@pratikkarad @prakarsh70
fix(MultiSelect): remove enter key select
db53ec1 
Co-authored-by: Prakarsh Shrivastava <[email protected]>
Co-authored-by: Pratik Karad <[email protected]>
@pratikkarad pratikkarad requested a review from a team as a code owner March 16, 2023 13:13
@prakarsh70
Copy link
Contributor

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Mar 16, 2023 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d2cebcf
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/641a00bdd591b00008644a0b
😎 Deploy Preview https://deploy-preview-13362--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 16, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d2cebcf
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/641a00bded98e50008dd441c
😎 Deploy Preview https://deploy-preview-13362--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

prakarsh70
prakarsh70 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@prakarsh70 prakarsh70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tw15egan
tw15egan requested changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is a linting error (MenuKeyDownEnter can be removed if it is not used), and the tests need to be updated to account for the new behavior (can change the failing tests' truthiness)

@pratikkarad
Copy link
Contributor Author

pratikkarad commented Mar 16, 2023 •
edited
Loading

Hey @tw15egan, I have corrected the lint error and test cases.
I had a question regarding running scoped test cases because it takes too much time to run the whole test suite.
Any suggestion on how I run the test suite only for a specific package?

@tw15egan
Copy link
Collaborator

@pratikkarad yeah, running the whole test suite is time-consuming. You can run specific tests by running this command from the root of the monorepo:

yarn test packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js --watch

If you use VS Code, you can also install the Jest extension, which lets you run specific tests inside the editor.

@pratikkarad
Copy link
Contributor Author

Thanks for the suggestion. I have updated the PR. PTAL, Thanks!

@pratikkarad pratikkarad requested review from tw15egan and removed request for andreancardona March 17, 2023 16:09
@tw15egan tw15egan requested a review from andreancardona March 17, 2023 16:13
@kodiakhq kodiakhq bot merged commit 702bbe6 into carbon-design-system:main Mar 21, 2023
@pratikkarad pratikkarad deleted the multiselect-13119 branch March 21, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakarsh70 prakarsh70 prakarsh70 approved these changes

@tw15egan tw15egan tw15egan approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@andreancardona andreancardona Awaiting requested review from andreancardona

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[a11y]: Revise MultiSelect keyboard selection behavior to not use enter
4 participants
@pratikkarad @prakarsh70 @tw15egan @tay1orjones