fix(treeview): increase hit area of twistie to 24px #13354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Unrelated to this PR, but it seems you can't collapse/expand these sections via keyboard. The style changes look good |
|
@tw15egan keyboard is working for me, for Treeview keyboard controls its left/right arrrows to open/close |
|
|
tw15egan
approved these changes
Mar 21, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13114, Closes #12769
Changelog
Changed
Testing / Reviewing
Visually Treeview should look identical to live storybook, but confirm that hit area for twistie arrow is now 24px
https://deploy-preview-13354--carbon-components-react.netlify.app/?path=/story/components-treeview--default