-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): update to React 18 #13332
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
421aa24
to
f42c9e5
Compare
…nstalled alongside framework packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is running as expected locally and tests are passing! 🔥
Looks like there's a conflict in one file @tay1orjones @francinelucca |
@francinelucca I believe its because I moved the |
Solved! @alisonjoseph @tw15egan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥
Closes #13220
Changelog
Changed
peerDependency
range for React to include v18 (in addition to v16 and v17)devDependencies
in published packages to use React 18@testing-library
deps to latest major versionuser-event
- every interaction viauserEvent
must now useawait
test-utils
to use thecreateRoot
apiTesting / Reviewing
Known issues, do not prevent merge
createRoot
API, so there's a console warning in storybook. This warning is present in versions <7 because storybook only updated their UI to react 18 in v7, it is safe to ignore. see Add support for React 18 storybookjs/storybook#17831 (comment)Click here to view the errors we had to address with this
render
, orclean
frompackages/test-utils/react.js
may need to be refactored to use@testing-library/react
instead@testing-library/react