fix(Modal): align button text to baseline #13320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
requested review from
a team and
thyhmdo
and removed request for
a team
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
approved these changes
Mar 16, 2023
|
@tw15egan Percy didn't catch it 🧐 |
|
@tay1orjones hmm, thought it would; it seems to have caught more minor changes... |
thyhmdo
approved these changes
Mar 20, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13319
Aligns the button text to the button baseline so the content will flow down instead of pushing up into the modal
Changelog
Changed
align-itemstobaselineTesting / Reviewing
Ensure when extra text wraps, it does not cause misalignment at the top of the text string.
cc @shixiedesign / @carbon-design-system/design Note: This will cause all text in Modals to be pushed down ~1px to align them all to the baseline. Percy should catch this; let me know if that is an okay tradeoff