feat(PasswordInput): add typescript types to PasswordInput #13311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
shryoo-ibm
changed the title
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
shryoo-ibm
force-pushed
the
add-types-password-input
branch
from
f47a668 to
a4416f2
Compare
shryoo-ibm
changed the title
tay1orjones
requested changes
Mar 16, 2023
shryoo-ibm
requested review from
tay1orjones
and removed request for
alisonjoseph
|
@shryoo-ibm looks like there's a minor conflict to resolve - just regen the allcontributors probably |
alisonjoseph
approved these changes
Mar 17, 2023
|
bump @shryoo-ibm looks like you have some minor conflicts to fix :) then we can review thanks! |
Ah okay, thanks! |
tay1orjones
approved these changes
Mar 24, 2023
tw15egan
pushed a commit
to tw15egan/carbon
that referenced
this pull request
Mar 31, 2023
…sign-system#13311) * refactor: add types to props in PasswordInput * refactor: make separate excluded attributes type * docs: contributor information * fix: remove feature condition and deprecated size --------- Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
|
Hey there! v11.26.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12550
Part of #12513, Adding TypeScript types to carbon react components
Changelog
Changed
Testing / Reviewing
Types can be tested by making a component and trying out the different property values.