refactor(Popover): add typescript types #13233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
francinelucca
added
status: failing CI 🙅♂️
status: ready for review 👀
and removed
status: failing CI 🙅♂️
labels
lewandom
force-pushed
the
typescript-popover
branch
from
7e09eab to
e6fc512
Compare
francinelucca
added
status: one more review 👀
and removed
status: ready for review 👀
labels
alisonjoseph
approved these changes
Mar 1, 2023
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hey there! v11.24.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13230
Add TypeScript support to Popover and PopoverContent components.
Changelog
New
Changed
Testing / Reviewing
The Popover component imports for the storybook should be valid and rendering. In a TypeScript environment, you should be able to import and reference the Popover component and its typings (PopoverProps).