feat(useContextMenu): add ref support #13210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #13209 I noticed that the
useContextMenu
currently only supports DOM elements (orwindow
ordocument
) as its trigger which means developers would need to wrapuseContextMenu
in auseEffect
in order to pass it the correctref.current
at all times.Since this feels a bit cumbersome and the
useContextMenu
hook already uses auseEffect
withtrigger
as its dependency, I updated the hook to directly support react refs.Changelog
New
trigger
argument inuseContextMenu
Testing / Reviewing
Menu should appear when right-clicking on the
div
, but not when right-clicking anywhere else on the screen.