-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(TableToolbarMenu): update tests to RTL #13172
Merged
kodiakhq
merged 6 commits into
carbon-design-system:main
from
alisonjoseph:12673-TableToolbarMenu-rtl
Feb 23, 2023
Merged
test(TableToolbarMenu): update tests to RTL #13172
kodiakhq
merged 6 commits into
carbon-design-system:main
from
alisonjoseph:12673-TableToolbarMenu-rtl
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
aledavila
approved these changes
Feb 23, 2023
aledavila
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12673
Updates TableToolbarMenu tests to RTL
Changelog
Changed
TableToolbarMenu
Testing / Reviewing
Ensure all tests pass and all props are covered by tests
yarn test packages/react/src/components/DataTable/__tests__/TableToolbarMenu-test.js