Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(Tile): Enzyme-> RTL - refactor out the render in setup #12806

Merged
merged 3 commits into from
Dec 8, 2022
Merged

test(Tile): Enzyme-> RTL - refactor out the render in setup #12806

merged 3 commits into from
Dec 8, 2022

Conversation

cknabe
Copy link
Contributor

@cknabe cknabe commented Dec 6, 2022

Relates to #12701

  • I removed the render* methods I previously added in the above PR.
  • I also added back in the prefix I removed.

@cknabe cknabe requested a review from a team as a code owner December 6, 2022 21:25
@netlify
Copy link

netlify bot commented Dec 6, 2022 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 078e699
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6391f799de44d900089acc5d
😎 Deploy Preview https://deploy-preview-12806--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 6, 2022 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 078e699
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6391f7996103530009fc9cc8
😎 Deploy Preview https://deploy-preview-12806--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tw15egan
tw15egan approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 880331a into carbon-design-system:main Dec 8, 2022
@carbon-bot
Copy link
Contributor

Hey there! v11.19.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cknabe @carbon-bot @alisonjoseph @tw15egan