-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(getInteractiveContent): add null checks #12789
fix(getInteractiveContent): add null checks #12789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tay1orjones!
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Based on some conversations with @fbarroso24: When using
react-test-renderer
to test components using this hook/function, the component will error withThis PR adds some null checks to avoid iterating over non-iterable Symbols passed to this function stemming from the
react-test-renderer
environment.Changelog
Changed
getInteractiveContent
to include null checksTesting / Reviewing