Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buttons): replace svg with inline svg #120

Merged
merged 1 commit into from
May 25, 2017
Merged

fix(buttons): replace svg with inline svg #120

merged 1 commit into from
May 25, 2017

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented May 25, 2017 •
edited
Loading

Replace Button SVG with Inline SVG

Changed

  • Updated Button
  • Fixed Icon transitions

Closes #102

@tw15egan tw15egan force-pushed the inline-svg/button branch from f77c9e6 to 60cb29e Compare May 25, 2017 20:02
hellobrian
hellobrian approved these changes May 25, 2017
View reviewed changes
Copy link
Contributor

@hellobrian hellobrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✅

@hellobrian hellobrian merged commit 2ed9d50 into carbon-design-system:master May 25, 2017
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
add for npmrc (carbon-design-system#120)
832b7b9
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
@hellobrian @iangfleming
fix(DetailPageHeader): add title to defaultProps (il8n) (carbon-desig…
c2a8d9e 
…n-system#120)
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 8, 2019
@conradennis @joshblack
fix(icons): update keyboard.svg (carbon-design-system#120)
73e5715
pbenson322 added a commit to pbenson322/carbon that referenced this pull request Mar 7, 2020
@pbenson322
Update icons.yml
81d9458 
Corrected titles for UI Icon Library noted in InVision (comments 1-124) with the exception of comment carbon-design-system#112 Logo Google and comment carbon-design-system#120 Logo StumbleUpon, which I can't find in the above coding. Also, awaiting an answer from Conrad Ennis on IoT connect (comment carbon-design-system#98) and Edt (comment carbon-design-system#102). While looking for content to update, I found other friendly names that needed correction, which aren't part of the UI Icon Library. They are as follows: Logo Instagram, Logo OpenShift®, Logo VMware, Logo Yelp, QR code, VMDK disk, WiFi, WiFi off, Covariate, Hashtag, Script, DNA, Erase 3D, MPEG, MPG2, DOC and PPT.
@pbenson322 pbenson322 mentioned this pull request Mar 17, 2020
Merged
joshblack added a commit that referenced this pull request Mar 19, 2020
@pbenson322 @joshblack @connor-leech
chore(icons): update friendly names in icons.yml (#5646)
122af4a 
* Update icons.yml

Corrected titles for UI Icon Library noted in InVision (comments 1-124) with the exception of comment #112 Logo Google and comment #120 Logo StumbleUpon, which I can't find in the above coding. Also, awaiting an answer from Conrad Ennis on IoT connect (comment #98) and Edt (comment #102). While looking for content to update, I found other friendly names that needed correction, which aren't part of the UI Icon Library. They are as follows: Logo Instagram, Logo OpenShift®, Logo VMware, Logo Yelp, QR code, VMDK disk, WiFi, WiFi off, Covariate, Hashtag, Script, DNA, Erase 3D, MPEG, MPG2, DOC and PPT.

* Update icons.yml

* Update packages/icons/icons.yml

Co-Authored-By: Josh Black <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Josh Black <[email protected]>

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Connor <[email protected]>
renmaddox referenced this pull request in renmaddox/carbon Mar 20, 2020
@pbenson322 @joshblack
@connor-leech @renmaddox
chore(icons): update friendly names in icons.yml (carbon-design-syste…
b1bb717 
…m#5646)

* Update icons.yml

Corrected titles for UI Icon Library noted in InVision (comments 1-124) with the exception of comment #112 Logo Google and comment #120 Logo StumbleUpon, which I can't find in the above coding. Also, awaiting an answer from Conrad Ennis on IoT connect (comment #98) and Edt (comment #102). While looking for content to update, I found other friendly names that needed correction, which aren't part of the UI Icon Library. They are as follows: Logo Instagram, Logo OpenShift®, Logo VMware, Logo Yelp, QR code, VMDK disk, WiFi, WiFi off, Covariate, Hashtag, Script, DNA, Erase 3D, MPEG, MPG2, DOC and PPT.

* Update icons.yml

* Update packages/icons/icons.yml

Co-Authored-By: Josh Black <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Josh Black <[email protected]>

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Connor <[email protected]>
renmaddox referenced this pull request in renmaddox/carbon Mar 20, 2020
@pbenson322 @joshblack
@connor-leech @renmaddox
chore(icons): update friendly names in icons.yml (carbon-design-syste…
8e04c4a 
…m#5646)

* Update icons.yml

Corrected titles for UI Icon Library noted in InVision (comments 1-124) with the exception of comment #112 Logo Google and comment #120 Logo StumbleUpon, which I can't find in the above coding. Also, awaiting an answer from Conrad Ennis on IoT connect (comment #98) and Edt (comment #102). While looking for content to update, I found other friendly names that needed correction, which aren't part of the UI Icon Library. They are as follows: Logo Instagram, Logo OpenShift®, Logo VMware, Logo Yelp, QR code, VMDK disk, WiFi, WiFi off, Covariate, Hashtag, Script, DNA, Erase 3D, MPEG, MPG2, DOC and PPT.

* Update icons.yml

* Update packages/icons/icons.yml

Co-Authored-By: Josh Black <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Josh Black <[email protected]>

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Connor <[email protected]>
@tw15egan tw15egan deleted the inline-svg/button branch April 28, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobrian hellobrian hellobrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tw15egan @hellobrian