Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datatable): limit description widths #11919

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Aug 5, 2022

Closes #11360

Changelog

New

  • provide a character-length-based max-width for data table descriptions per breakpoint

Changed

  • lengthen the table description on batch actions story

Testing / Reviewing

  • View the datatable/with batch actions story, review the description width at different breakpoints
  • Review and approve snapshot changes in Percy status check
description.max.width.mov

@netlify
Copy link

netlify bot commented Aug 5, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ca76c4b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62f11e6044b02c0008b88171
😎 Deploy Preview https://deploy-preview-11919--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 5, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ca76c4b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62f11e60a822d5000869c475
😎 Deploy Preview https://deploy-preview-11919--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit d1d0f84 into carbon-design-system:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Responsive Data Table Description Widths
3 participants