-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): enable react ^18 in peerDeps #11826
Conversation
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I have read the DCO document and I hereby sign the DCO. |
@tay1orjones adding a third set of eyes on this change |
Hi there @falsepopsky! Thanks for proposing this change. Unfortunately we haven't finished formal support for React 18 yet and so can't merge this until we land #11308 The two workarounds you listed are the recommended path for now until we can validate React 18 support within the project. |
Summary
When you are working with
react
+react-dom
version ">=18" and you try to install this package@carbon/react
npm throw an error, like thisSo you have 2 options
peerDependencies
inpackage.json
inreact
andcarbon-components-react
packagesNew
Changed
Removed
Testing / Reviewing