fix(tabletoolbarsearch): update default size to be lg #11621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aledavila
approved these changes
Jun 15, 2022
jnm2377
approved these changes
Jun 15, 2022
|
@tay1orjones seems like some snapshots need to be updated plus percy and then should be good to go! |
|
@tay1orjones does this fix the issue over in: #11492 as well? |
|
@joshblack yep, thanks for the reminder, I just closed in favor of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11446
Surfaced in slack
We updated the default size of Search to be
md#10643. The TableToolbarSearch had so far been relying on the previous default, which was larger. Whensizewas not specified to TableToolbarSearch, this was causing issues with alignment in the search button. You can see the bug here. Some stories are not impacted by this because the story controls provide a different default (lg).Changelog
New
sizeprop to TableToolbarSearch, default it tolgTesting / Reviewing
The following datatable stories should be fixed: