Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): correct actionable inline text wrapping layout/reflow #11594

Merged

Conversation

tay1orjones
Copy link
Member

Closes #11593

Changelog

Changed

  • Update ActionableNotification text container styles to wrap

Testing / Reviewing

  • Review ActionableNotification story with inline='true', replace title and subtitle with long text.
  • Layout of wrapped text should stack vertically instead of horizontally
    • Below the left side is the defect, right side is this fix:
      • image
  • Ensure other notification stories and breakpoints are not impacted by the change.

@tay1orjones tay1orjones requested a review from a team as a code owner June 10, 2022 15:29
@tay1orjones tay1orjones requested review from joshblack and dakahn June 10, 2022 15:29
@netlify
Copy link

netlify bot commented Jun 10, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit be81e45
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62a8a896df28ff0008a1de86
😎 Deploy Preview https://deploy-preview-11594--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 10, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit be81e45
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62a8a896a8eb1f0009c5fba0
😎 Deploy Preview https://deploy-preview-11594--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 88d7121 into carbon-design-system:main Jun 14, 2022
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
* fix: side panel story slug

* fix: remove slug slot in story

* fix: remove slug-container classname

---------

Co-authored-by: Ariella Gilmore <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Alignment issue with Actionable Notification
3 participants