fix(Datepicker): change role on calendar container to 'application' #11570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakahn
requested review from
joshblack,
abbeyhrt and
tay1orjones
and removed request for
joshblack
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
1 task
tay1orjones
approved these changes
Jun 15, 2022
abbeyhrt
approved these changes
Jun 16, 2022
tay1orjones
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Jul 21, 2022
…arbon-design-system#11570) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
dakahn
added a commit
that referenced
this pull request
Jul 26, 2022
…11570) (#11838) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: D.A. Kahn <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11438
Closes #8454
The calendar was unusable with JAWS. Date selection was not possible @mbgower 's suggestion in #11438 worked perefectly. So this PR implements that change.
Datepicker is now a
role="application"on the calendar div 👍🏾Testing / Reviewing
With JAWS 2022 make sure that the dates on the calendar are accessible/selectable/and read in a reasonable and understandable way.