-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TreeView): prevent disabled node selection and expansion #11520
fix(TreeView): prevent disabled node selection and expansion #11520
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hey @emyarod thanks for opening this. Maybe I'm missing something, but when I test in the current storybook example of Screen.Recording.2022-06-01.at.1.00.13.PM.mov |
@jnm2377 the PR will also prevent expansion and collapsing when clicking disabled toggle buttons this is the current storybook behavior: Screen.Recording.2022-06-01.at.15.05.26.mov |
Related #6792
Related #11402
This PR prevents keyboard shortcuts and mouse interactions to affect disabled tree node expansion and selection states
Changelog
New
Changed
Testing / Reviewing
the existing keyboard shortcuts should still function as expected except for disabled tree nodes
reviewers can also hide whitespace changes in GitHub for a cleaner diff on the style changes