fix(react): remove unnecessary title for icon description #11490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
May 25, 2022
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
7 tasks
dakahn
approved these changes
May 31, 2022
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
…design-system#11532) ### Related Ticket(s) Closes carbon-design-system#11490 ### Description In Date picker element, dev tool console shows error `Uncaught TypeError: fp.getDateStr is not a function`. ### Changelog **Removed** - Removed custom event handling function. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF #11444
Removes unnecessary title in
IconElementinOverflowMenu. It was causing this violation in AC checker:Because it seemed to be sensing the
titleas the visible title for OverflowMenu and so thearia-labelfor OverflowMenu doesn't match. I could have updated theariaLabelin the story to match but the way the violation worked,ariaLabelandiconDescriptionwould always need to match which doesn't make sense.As far as I can tell the
titlewasn't doing anything. The icon is already aria labelled throughiconDescriptionand that is read by VO. I was unable to get thetitleto be read and so it seemed unnecessary.Changelog
New
Changed
Removed
Testing / Reviewing
Verify that OverflowMenu has no violations in AC checker and is read by VO correctly.