fix(datepicker): remove component export toggle #11416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
aledavila
approved these changes
May 13, 2022
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
joshblack
approved these changes
May 16, 2022
2 tasks
dakahn
approved these changes
May 16, 2022
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
…design-system#11416) ### Related Ticket(s) Closes carbon-design-system#11178 carbon-design-system#11481 ### Description Sorting and Expansion option works individually, but sorting is not working when used along with expansion option in Data Table. Checking for `is-sortable` attribute during initial load seems to fix this issue. Selection option is enabled for Data table by default without adding the is-selectable attribute to the table element. ### Changelog **New** - A function to handle the sorting action is added. **Changed** - `is-sortable` attribute was being checked only for changeAttribute cases, this is updated to check on initial load too. - Added a condition to check if is-selectable attribute is added to the Data table component <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11378
Closes #11342
Changelog
Changed
/nextRemoved
DatePicker,DatePickerInputcomponent export toggle and associated/stale files and foldersTesting / Reviewing