Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add line height to unsortable columns on sortable datatable (#9311) #11400

Closed
wants to merge 1 commit into from
Closed

fix: add line height to unsortable columns on sortable datatable (#9311) #11400

wants to merge 1 commit into from

Conversation

pmweeks98
Copy link
Contributor

Closes #

#9311

Changelog

Changed

Added lineheight to ensure the correct font size is used in unsortable columns

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@pmweeks98 pmweeks98 requested a review from a team as a code owner May 12, 2022 14:29
@pmweeks98 pmweeks98 requested review from abbeyhrt and jnm2377 May 12, 2022 14:29
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022 •
edited
Loading

DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:

I have read the DCO document and I hereby sign the DCO.

Pádraig Weeks seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@netlify
Copy link

netlify bot commented May 12, 2022

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 321760e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/627d19e25904fb0008470d60
😎 Deploy Preview https://deploy-preview-11400--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 12, 2022

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 321760e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/627d19e21a34bd0009fea3e7
😎 Deploy Preview https://deploy-preview-11400--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pmweeks98
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@pmweeks98
Copy link
Contributor Author

recheck

@pmweeks98
Copy link
Contributor Author

pmweeks98 commented May 12, 2022 •
edited
Loading

DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:

I have read the DCO document and I hereby sign the DCO.

Pádraig Weeks seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.You can retrigger this bot by commenting recheck in this Pull Request

recheck

@pmweeks98 pmweeks98 closed this May 12, 2022
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@ko1ebayev
fix(dropdown): remove excess border of first dropdown element (carbon…
5b04354 
…-design-system#11400)

### Related Ticket(s)

carbon-design-system#11271 

Closes carbon-design-system#11271 

### Description

Just querying first element of dropdown and removing its `border-block-start-width`

### Changelog

**Changed**

- updated `dropdown.scss` with 5 new lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt abbeyhrt was automatically assigned from carbon-design-system/developers-system

@jnm2377 jnm2377 Awaiting requested review from jnm2377 jnm2377 was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pmweeks98