-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ComposedModal): wrap modal content in div to get VO in iOS working #11350
fix(ComposedModal): wrap modal content in div to get VO in iOS working #11350
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@annawen1 one thing that may be happening with VO on iOS is that This could also totally be wrong haha, figured I'd share in case it helped out at all! |
@joshblack yeah that was the #1 solution that I've seen when searching online, but we do have similar focus wrap logic for our web components locale modal that's working on VO iOS so I'm trying to see why it doesn't do the same 🤔 UPDATE: weird, but it works when I use another |
packages/react/src/components/ComposedModal/next/ComposedModal.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/ComposedModal/next/ComposedModal.js
Outdated
Show resolved
Hide resolved
### Related Ticket(s) carbon-design-system#11350 ### Description Our current docs lack some of the events our components dispatch, this includes them in the JSDoc description using `@fires`. ### Changelog **New** - added missing events from component docs in CWC <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Closes #11046
VO on iOS - focus was not getting trapped in the
ComposedModal
. When user swipes through modal content, expected behavior is the focus will loop back to start of modal instead of going out into the browser tool bar.BEFORE:
RPReplay_Final1652120455.mov
AFTER: (I'm swiping back and forth to ensure both start and end sentinels redirect focus back within the modal)
RPReplay_Final1652120296.mov
Changelog
Changed
cds--modal-container-body
class for stylingTesting / Reviewing