Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slider): ensure slider and input are both labelled by the label #10400

Merged
merged 3 commits into from
Jan 14, 2022
Merged

fix(slider): ensure slider and input are both labelled by the label #10400

merged 3 commits into from
Jan 14, 2022

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jan 12, 2022 •
edited
Loading

Refs #10252 #10172

  1. The label is associated with the slider via htmlFor
  2. The slider no longer has the redundant aria-labelledby
  3. The input is aria-labelledby the label when a more explicit ariaLabelInput is not passed
  4. If a ariaLabelInput is passed, the input does not receive aria-labelledby and instead receives aria-label={ariaLabelInput}

Changelog

Changed

  • slider: improve aria labels

Testing / Reviewing

  • View the storybook to see that the above bullet list statements are true. It'll be slightly different with the v11 flag since the ariaLabelInput doesn't receive a default.

@tay1orjones tay1orjones requested a review from a team as a code owner January 12, 2022 23:09
@netlify
Copy link

netlify bot commented Jan 12, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 14c9d4a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61e1a9c95bd6c900078d5044

😎 Browse the preview: https://deploy-preview-10400--carbon-react-next.netlify.app

@tay1orjones
Copy link
Member Author

tay1orjones commented Jan 12, 2022 •
edited
Loading

@mbgower I think this hits more of the mark you were aiming for in your original issue?

@tay1orjones tay1orjones self-assigned this Jan 12, 2022
@netlify
Copy link

netlify bot commented Jan 12, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 14c9d4a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61e1a9c95bd6c900078d5042

😎 Browse the preview: https://deploy-preview-10400--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 12, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 14c9d4a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61e1a9c9e42094000865a357

😎 Browse the preview: https://deploy-preview-10400--carbon-components-react.netlify.app

abbeyhrt
abbeyhrt approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kodiakhq kodiakhq bot merged commit c235676 into carbon-design-system:main Jan 14, 2022
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@kennylam
chore(mixin): import carbon-components mixin (carbon-design-system#…
8dccf53 
…10400)

* chore(mixin): import carbon-component into package

* chore(deps): bump package version to beta.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@joshblack joshblack Awaiting requested review from joshblack joshblack was automatically assigned from carbon-design-system/developers-system

Assignees

@tay1orjones tay1orjones

Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tay1orjones @abbeyhrt @dakahn @joshblack