Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(project): update fs-extra to 10.x #10299

Merged
merged 3 commits into from
Jan 4, 2022
Merged

chore(project): update fs-extra to 10.x #10299

merged 3 commits into from
Jan 4, 2022

Conversation

joshblack
Copy link
Contributor

This PR consolidates differing versions of fs-extra to 10.x across the monorepo.

Changelog

New

Changed

  • Update packages that use fs-extra to 10.x
  • Update tests in icon-build-helpers to resolve issue where memfs was not defining fs.realpath.native

Removed

Testing / Reviewing

  • Verify tests pass as expected

@joshblack joshblack requested a review from a team as a code owner December 15, 2021 21:33
@joshblack joshblack requested review from abbeyhrt and dakahn December 15, 2021 21:33
@netlify
Copy link

netlify bot commented Dec 15, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 116014e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61d482054a665e00085b23d9

😎 Browse the preview: https://deploy-preview-10299--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 116014e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d48205c95f320008f041b6

😎 Browse the preview: https://deploy-preview-10299--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 116014e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d482050bf49500070d7ff9

😎 Browse the preview: https://deploy-preview-10299--carbon-components-react.netlify.app

abbeyhrt
abbeyhrt approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kodiakhq kodiakhq bot merged commit 253af11 into carbon-design-system:main Jan 4, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @abbeyhrt @dakahn