Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): fix for sub menu positioning #10278

Merged
merged 5 commits into from
Jan 4, 2022
Merged

fix(menu): fix for sub menu positioning #10278

merged 5 commits into from
Jan 4, 2022

Conversation

jakubfaliszewski
Copy link
Contributor

Closes #10260

Adds additional calculations for sub-menus, that are rendered upwards. It's based on menu spacing/sizes, so it's flexible and works correctly for different sizes (sm, md, lg, custom)

standard

Complex menu demo

complex

Large menu demo

lg

Changelog

Fixed

  • positioning of sub-menus

Testing / Reviewing

Follow the step from GIFs and experiment a little with the styling.

@netlify
Copy link

netlify bot commented Dec 11, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: edc02eb

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61d48a609f19e4000874f889

😎 Browse the preview: https://deploy-preview-10278--carbon-react-next.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2021 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@jakubfaliszewski jakubfaliszewski mentioned this pull request Dec 11, 2021
Closed
2 tasks
@jakubfaliszewski
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Dec 11, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d576774

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61b489f1a8fce300070f6001

😎 Browse the preview: https://deploy-preview-10278--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 11, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d576774

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61b489f16d82f000086f9482

😎 Browse the preview: https://deploy-preview-10278--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Dec 11, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: edc02eb

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61d48a601f18de00074e9eb3

😎 Browse the preview: https://deploy-preview-10278--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 11, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: edc02eb

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61d48a6052b5190008fd39ef

😎 Browse the preview: https://deploy-preview-10278--carbon-components-react.netlify.app

@jakubfaliszewski jakubfaliszewski marked this pull request as ready for review December 14, 2021 07:26
@jakubfaliszewski jakubfaliszewski requested a review from a team as a code owner December 14, 2021 07:26
@joshblack
Copy link
Contributor

cc @janhassel

@kodiakhq kodiakhq bot merged commit 846df76 into carbon-design-system:main Jan 4, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
Closed
22 tasks
@jakubfaliszewski
Copy link
Contributor Author

@all-contributors please add @jakubfaliszewski for code

@allcontributors allcontributors bot mentioned this pull request Apr 13, 2022
Merged
@allcontributors
Copy link
Contributor

@jakubfaliszewski

I've put up a pull request to add @jakubfaliszewski! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhassel janhassel janhassel requested changes

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Menu - sub-menus are not rendering correctly when there's not enough space below
4 participants
@jakubfaliszewski @joshblack @janhassel @dakahn