Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(react): update pagination component to functional component #10082

Merged
merged 11 commits into from
Nov 17, 2021
Merged

refactor(react): update pagination component to functional component #10082

merged 11 commits into from
Nov 17, 2021

Conversation

joshblack
Copy link
Contributor

Closes #10021

Refactor our Pagination component to a functional component

Changelog

New

  • Add Pagination/next folder with refactored Pagination
  • Update Pagination tests to work without wrapper.state() or wrapper.setState() calls

Changed

Removed

Testing / Reviewing

  • Verify tests pass as expected
  • Verify Pagination behaves identical in new and old storybooks

@joshblack joshblack requested a review from a team as a code owner November 10, 2021 16:00
@joshblack joshblack requested a review from abbeyhrt November 10, 2021 16:01
@joshblack joshblack changed the title 10021 refactor pagination component refactor(react): update pagination component to functional component Nov 10, 2021
@netlify
Copy link

netlify bot commented Nov 10, 2021 •
edited
Loading

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: e2b52f8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/618becaeaf977c0007a1f2f0

@netlify
Copy link

netlify bot commented Nov 10, 2021

❌ Deploy Preview for carbon-components-react failed.

🔨 Explore the source changes: e2b52f8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/618becaea90d8e0007c1536b

@netlify
Copy link

netlify bot commented Nov 10, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 8c54f2d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61946340a4617a00087e938f

😎 Browse the preview: https://deploy-preview-10082--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Nov 10, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e2b52f8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/618becae69e2600007ce61a2

😎 Browse the preview: https://deploy-preview-10082--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 10, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 8c54f2d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/619463406014e8000753bde4

😎 Browse the preview: https://deploy-preview-10082--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Nov 10, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 8c54f2d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6194634074ee470008d0ec81

😎 Browse the preview: https://deploy-preview-10082--carbon-elements.netlify.app

@dakahn
Copy link
Contributor

dakahn commented Nov 11, 2021

although you're probably aware -- the error i'm getting when i run carbon-react storybook
image

dakahn
dakahn approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍🏾

abbeyhrt
abbeyhrt reviewed Nov 12, 2021
View reviewed changes
packages/react/src/components/Pagination/next/Pagination.stories.js
number,
select,
text,
} from '@storybook/addon-knobs';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to start removing knobs if the story is going to be in carbon-react-next?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, maybe this can be part of our refactor during our mob days next sprint?

@joshblack joshblack requested a review from abbeyhrt November 16, 2021 16:18
@kodiakhq kodiakhq bot merged commit df40c35 into carbon-design-system:main Nov 17, 2021
@abbeyhrt abbeyhrt mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@sstrubberg sstrubberg Awaiting requested review from sstrubberg sstrubberg was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pagination]: upgrade to functional component
3 participants
@joshblack @dakahn @abbeyhrt