Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVT 2 DatePicker date field placeholder fails contrast for regular text #4231

Closed
snidersd opened this issue Oct 4, 2019 · 0 comments · Fixed by #4799
Closed

AVT 2 DatePicker date field placeholder fails contrast for regular text #4231

snidersd opened this issue Oct 4, 2019 · 0 comments · Fixed by #4799
Assignees
@asudoh
Labels
package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛

Comments

@snidersd
Copy link

snidersd commented Oct 4, 2019

Environment

macOS Mojave version 10.14.6
Chrome Version Version 77.0.3865.90
Carbon v10 - React
Color Contrast Analyzer

Detailed Description

Go to the React Datepicker Component
Run Color Contrast Analyzer and test the search placeholder text against the background color (see screenshot):
Screen Shot 2019-10-04 at 1 41 47 PM
@dakahn dakahn added the severity: 1 https://ibm.biz/carbon-severity label Oct 15, 2019
@dakahn dakahn added this to the DatePicker - A11y Project Team milestone Oct 15, 2019
@dakahn dakahn modified the milestones: DatePicker - A11y Project Team, Carbon WCAG Compliance Nov 21, 2019
@dakahn dakahn mentioned this issue Nov 22, 2019
Closed
asudoh added a commit to asudoh/carbon-components that referenced this issue Nov 29, 2019
@asudoh
fix(styles): update placeholder colors
6bd1b43 
This change updates placeholder color from `$text-03` to `$text-05` to
meet the color contrast requirement.

This change also replaces manual usage of colors in style rules with
the Sass mixin for placeholder `@include placeholder-colors`.

Fixes carbon-design-system#4231.
@asudoh asudoh mentioned this issue Nov 29, 2019
Merged
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
asudoh added a commit that referenced this issue Dec 19, 2019
@asudoh
fix(styles): update placeholder colors (#4799)
ed077c6 
This change updates placeholder color of some components from
`$text-03` to e.g. `$text-05` to meet the color contrast requirement.

This change also replaces manual usage of colors in style rules with
the Sass mixin for placeholder `@include placeholder-colors`.

Fixes #4231.
joshblack pushed a commit to joshblack/carbon that referenced this issue Jan 6, 2020
@asudoh @joshblack
fix(styles): update placeholder colors (carbon-design-system#4799)
69d495a 
This change updates placeholder color of some components from
`$text-03` to e.g. `$text-05` to meet the color contrast requirement.

This change also replaces manual usage of colors in style rules with
the Sass mixin for placeholder `@include placeholder-colors`.

Fixes carbon-design-system#4231.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asudoh asudoh

Labels
package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(styles): update placeholder colors asudoh/carbon-components
4 participants
@asudoh @mattrosno @snidersd @dakahn