Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Share/document grid examples, including full-width option #2803

Closed
jendowns opened this issue May 22, 2019 · 2 comments
Closed

[Grid] Share/document grid examples, including full-width option #2803

jendowns opened this issue May 22, 2019 · 2 comments
Labels
status: inactive Will close if there's no further activity within a given time type: enhancement 💡

Comments

@jendowns
Copy link
Contributor

jendowns commented May 22, 2019

Hey everyone, our Security devs are starting to implement the new Grid, and all they really have is the Usage section of the Grid package README:

https://github.com/carbon-design-system/carbon/tree/master/packages/grid#usage

I have also shared this page with them with examples:

https://carbon-elements.netlify.com/grid/examples/preview/

But it would be very helpful to have that preview page surfaced in a more official way. The examples there are great and have been helpful, but not everyone knows about it (as far as I know it isn't linked in the Grid package README, or on carbondesignsystem.com)

@stale
Copy link

stale bot commented Jun 21, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 21, 2019
@stale
Copy link

stale bot commented Jun 24, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Jun 24, 2019
joshblack added a commit that referenced this issue Jan 29, 2020
* feat(grid): add hiding columns with width 0

Adds functionality requested in (#2435) with more convenient syntax

* docs(grid): add example of hiding columns

* docs(grid): fix incorrect `bleed` info and typos

* docs(grid): add link to live demo website

Change requested here in (#2803)

* feat(grid): implement functional React component

* chore(grid): add generated files

* fix(docs): storybook support load CSF & add sort

* docs(Grid): update valid props

additionally:
- fix oneOf not using array
- label default props as undefined
- convert col width from str -> num
- add range func

* docs(Grid): add initial story & style margins

* docs(Grid): clean up doc styles & knob controls

* docs(Grid): add color knobs, pass thru params

* docs(Grid): fix minor fullwidth disp bug

* test(Grid): add smoke tests for root el

* test(Grid): add basic row and col tests

* test(Grid): fix wrappers & update index snapshot

* feat(Grid): use layout's breakpoints

* chore(Grid): port all tests, add 'as' prop

* docs(Grid): include stories from #3892

* feat(Grid): support obj syntax & rm offset props

* fix(Grid): add missing @carbon/layout pkg

* feat(Grid): rm `noGutter` prop for later PR

* chore(Grid): revert storybook to 5.2.1

* chore(Grid): convert to recommended syntax

* chore(Grid): inline array gen helper

* fix(Grid): update incorrect prop types

* chore(Grid): update import format

* Revert sass.md

* Revert _mixins.scss

* Revert App.js

* refactor(grid): split out files and update Column

* refactor(grid): update test suite for grid components

* docs(grid): update story for grid

* fix(react): update entrypoint with grid components

* fix(grid): convert story offset to prop obj

* fix(react): update with missing prop values

* chore(project): sync offline mirror

Co-authored-by: Josh Black <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: inactive Will close if there's no further activity within a given time type: enhancement 💡
Projects
None yet
Development

No branches or pull requests

1 participant