Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Add a secondary style #1329

Closed
stanislavgeorgiev opened this issue Oct 24, 2018 · 19 comments · Fixed by #4431
Closed

[Tabs] Add a secondary style #1329

stanislavgeorgiev opened this issue Oct 24, 2018 · 19 comments · Fixed by #4431

Comments

@stanislavgeorgiev
Copy link
Contributor

stanislavgeorgiev commented Oct 24, 2018

Summary

My project requires an alternative styling for the Tabs component which looks like this:

image

I can make the style updates this or next week and contribute it back if that new design is deemed to be useful to Carbon. Any notes from Design to make the above style compliant with the Carbon are very much welcome.
(https://ibm-studios.slack.com/archives/C0M053VPT/p1540402619000100?thread_ts=1540400543.000100&cid=C0M053VPT)

@alisonjoseph
Copy link
Member

@IBM/carbon-designers fyi

@jeanservaas
Copy link
Collaborator

@stanislavgeorgiev

This is what's coming down the pipe for Carbon v11. Like I said, these guys are spec'd but are not going to make the Carbon X release. Also note, they're in the new design language style... and we're still hammering out our color tokens for the light theme.

If you want to contribute something back to Carbon, it would make sense to use this structure. @aagonzales suggested you could just use the existing Carbon colors in the meantime...

tabs_light_theme_1
tabs_specs_2

@stanislavgeorgiev
Copy link
Contributor Author

Thanks @jeanservaas, that's going to be very helpful!
When would those changes end up in master if I make them?

@jeanservaas
Copy link
Collaborator

There's no reason a tab variation couldn't go into the Experimental components right away. The reason we're not doing it is that we have limited resources so we have to focus just on matching what's in Carbon right now for the X release. If your team develops it to spec we could try to include it for X.

@tw15egan
Copy link
Collaborator

@stanislavgeorgiev you can take a look at our other components that have experimental versions to see how we are going about it:

https://github.com/IBM/carbon-components/blob/master/src/components/list/_list.scss

@stale
Copy link

stale bot commented May 2, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@stale stale bot added the wontfix label May 2, 2019
@aagonzales
Copy link
Member

This is something we will need. I've already seen teams like Cloud using this in their designs. Not stale.

@shixiedesign
Copy link
Contributor

Hi @stanislavgeorgiev ! Just wanna check in to see if you've got to create the secondary style for Tabs. Keep us posted and lemme know if you need any additional info/spec. Thanks!

@stanislavgeorgiev
Copy link
Contributor Author

@shixiedesign No, I haven't had a chance to work on it yet. I may get some time in several week to work on this.

@shixiedesign shixiedesign changed the title Tabs: Add a secondary style [Tabs] Add a secondary style May 13, 2019
@stale
Copy link

stale bot commented Jun 19, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 19, 2019
@aagonzales aagonzales removed the status: inactive Will close if there's no further activity within a given time label Jun 21, 2019
@laurenmrice
Copy link
Member

not stale

@stale
Copy link

stale bot commented Aug 9, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 9, 2019
@aagonzales aagonzales removed the status: inactive Will close if there's no further activity within a given time label Aug 9, 2019
@stanislavgeorgiev
Copy link
Contributor Author

stanislavgeorgiev commented Aug 10, 2019 via email

@jeanservaas
Copy link
Collaborator

Also, like @aagonzales we've seen these designs from Intratstructure and Containers teams -- I know Erica Raymond was taking about contributing it back to Carbon. I'll follow up with her on it too.

@stale
Copy link

stale bot commented Sep 11, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Sep 11, 2019
@stanislavgeorgiev
Copy link
Contributor Author

Still active

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Sep 11, 2019
@asudoh
Copy link
Contributor

asudoh commented Oct 16, 2019

@jeanservaas @aagonzales Looking at the spec image, which has several IBM color references. Do we have mappings of those to our theme tokens? (My apologies if I'm missing something) Thanks!

@aagonzales
Copy link
Member

Nope, we didn't have the tokens on there. Here's the spec with color tokens

tabs

@asudoh
Copy link
Contributor

asudoh commented Oct 17, 2019

Super 🎉 - Thanks a lot @aagonzales!

asudoh added a commit to asudoh/carbon-components that referenced this issue Oct 23, 2019
The new variant is enabled with `.bx--tabs--fixed` class.

Fixes carbon-design-system#1329.
asudoh added a commit that referenced this issue Oct 25, 2019
The new variant is enabled with `.bx--tabs--fixed` class.

Fixes #1329.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.