Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental tile: Add a new color token for the icon #13217

Closed
1 task
Tracked by #12278
thyhmdo opened this issue Feb 17, 2023 · 1 comment · Fixed by #13219
Closed
1 task
Tracked by #12278

Experimental tile: Add a new color token for the icon #13217

thyhmdo opened this issue Feb 17, 2023 · 1 comment · Fixed by #13219
Assignees
@tw15egan
Labels
component: tile role: dev 🤖 version: 11 Issues pertaining to Carbon v11
Milestone
2023 Q1

Comments

@thyhmdo
Copy link
Member

thyhmdo commented Feb 17, 2023 •
edited
Loading

Background: This work started with icons placed at the bottom right in tiles. Using the $interactive token does not pass the accessibility requirements in dark themes. We wanted to create a new color token for this icon. This can also apply to other elements in the future.

Token name: $icon-interactive

  • White and Gray 10 theme: Blue 60 #0f62fe

  • Gray 90 and Gray 100 theme: White #ffffff

  • Develop the token (developer)
@thyhmdo thyhmdo mentioned this issue Feb 17, 2023
Closed
@thyhmdo thyhmdo changed the title Create a new token for the icon Create a new color token for the icon Feb 17, 2023
@thyhmdo thyhmdo self-assigned this Feb 17, 2023
@sstrubberg sstrubberg mentioned this issue Feb 20, 2023
Closed
4 tasks
@thyhmdo thyhmdo removed their assignment Feb 20, 2023
@tw15egan
Copy link
Collaborator

tw15egan commented Feb 23, 2023 •
edited
Loading

@thyhmdo I will move this over to the core carbon repo so we can add it to the theme package 👍🏻

@tw15egan tw15egan transferred this issue from carbon-design-system/carbon-website Feb 23, 2023
@tw15egan tw15egan self-assigned this Feb 23, 2023
@tw15egan tw15egan moved this from ⏱ Backlog to 🏗 In Progress in Design System Feb 23, 2023
@aagonzales aagonzales changed the title Create a new color token for the icon Experimental tile: Add a new color token for the icon Feb 23, 2023
@tay1orjones tay1orjones added this to the 2023 Q1 milestone Feb 23, 2023
@tw15egan tw15egan mentioned this issue Feb 23, 2023
Merged
@aagonzales aagonzales mentioned this issue Feb 23, 2023
Closed
@kodiakhq kodiakhq bot closed this as completed in #13219 Mar 2, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
component: tile role: dev 🤖 version: 11 Issues pertaining to Carbon v11
Projects
Design System
Archived in project
Milestone
2023 Q1
Development

Successfully merging a pull request may close this issue.

feat(theme): add $icon-interactive token tw15egan/carbon
3 participants
@tay1orjones @tw15egan @thyhmdo