-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental tile: code implementation #12464
Comments
code
implementation
code
implementation
We talked about this today 11/3 at design crit:
Based on this, I skew towards some type of global feature flag (maybe just in sass?) that consumers can turn on at one place to apply to their entire app. Adding a prop or a new unstable export are not desirable approaches because they both would mean that we need to write a codemod to facilitate quick conversion so migration isn't a long process. |
For the storybook, we'll likely have to ship additional styles scoped to a specific story. Something like this: // tile-story-styles.scss
@use '@carbon/react/scss/components/tile` with (
$experimental-improved-tile-contrast: true
);
.scope-to-custom-class {
@include tile.tile();
} |
* feat(tile): add experimental improved contrast tile closes #12464 * Update ExperimentalTile.stories.js * feat(tile): update feature flag and story * feat(tile): add experimental tile feature flag docs * feat(tile): add improved contrast to vrt * chore: move improved tile to experimental section in storybook * chore: docs Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This issue is for the primary implementation of the new experimental tile variant.
At it's core, the required changes are likely just styling placed behind a new classname/selector.
There's a few ideas on the "toggle mechanism" we could use to allow consumers to flip on the new styling:
via a newhasImprovedContrast
(naming tbd) prop onTile
Through a whole new component exports,unstable__Tile
,unstable__SelectableTile
, etc.via a context wrapper component (feature flag) - this would enable certain sections of an app's tiles to use the new variantReally it depends on feedback we get:
#12464 (comment)
The text was updated successfully, but these errors were encountered: