fix(styes): add error handling for rem & em sass functions

carbon-design-system · Dec 20, 2019 · e8cba9f · e8cba9f
1 parent 8911fe8
commit e8cba9f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/packages/components/src/globals/scss/_typography.scss b/packages/components/src/globals/scss/_typography.scss
@@ -22,6 +22,10 @@ $base-font-size: 16px !default;
 /// @group global-typography
 /// @deprecated (For v10) Use `carbon--rem()`
 @function rem($px) {
+  @if unit($px) != 'px' {
+    @error "Argument `#{$px}` must be a value in pixels.";
+  }
+
   @return ($px / $base-font-size) * 1rem;
 }
 
@@ -33,6 +37,10 @@ $base-font-size: 16px !default;
 /// @group global-typography
 /// @deprecated (For v10) Use `carbon--em()`
 @function em($px) {
+  @if unit($px) != 'px' {
+    @error "Argument `#{$px}` must be a value in pixels.";
+  }
+
   @return ($px / $base-font-size) * 1em;
 }
 

diff --git a/packages/layout/scss/_convert.scss b/packages/layout/scss/_convert.scss
@@ -17,6 +17,10 @@ $carbon--base-font-size: 16px !default;
 /// @access public
 /// @group @carbon/layout
 @function carbon--rem($px) {
+  @if unit($px) != 'px' {
+    @error "Argument `#{$px}` must be a value in pixels.";
+  }
+
   @return ($px / $carbon--base-font-size) * 1rem;
 }
 
@@ -26,5 +30,9 @@ $carbon--base-font-size: 16px !default;
 /// @access public
 /// @group @carbon/layout
 @function carbon--em($px) {
+  @if unit($px) != 'px' {
+    @error "Argument `#{$px}` must be a value in pixels.";
+  }
+
   @return ($px / $carbon--base-font-size) * 1em;
 }