fix(multiselect): remove aria-label

carbon-design-system · Jan 21, 2020 · 5691507 · 5691507
1 parent 806d162
commit 5691507
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/react/src/components/ListBox/ListBoxMenu.js b/packages/react/src/components/ListBox/ListBoxMenu.js
@@ -23,7 +23,6 @@ const ListBoxMenu = ({ children, id, ...rest }) => (
     id={`${id}__menu`}
     className={`${prefix}--list-box__menu`}
     role="listbox"
-    aria-multiselectable="true"
     {...rest}>
     {children}
   </div>

diff --git a/packages/react/src/components/MultiSelect/MultiSelect.js b/packages/react/src/components/MultiSelect/MultiSelect.js
@@ -356,7 +356,10 @@ export default class MultiSelect extends React.Component {
                     />
                   </ListBox.Field>
                   {isOpen && (
-                    <ListBox.Menu aria-labelledby={`${labelId}`} id={id}>
+                    <ListBox.Menu
+                      aria-multiselectable="true"
+                      aria-labelledby={`${labelId}`}
+                      id={id}>
                       {sortItems(items, {
                         selectedItems: {
                           top: selectedItems,
@@ -382,7 +385,6 @@ export default class MultiSelect extends React.Component {
                             tabIndex={-1}
                             isHighlighted={highlightedIndex === index}
                             title={itemText}
-                            aria-label={itemText}
                             {...itemProps}>
                             <div className={`${prefix}--checkbox-wrapper`}>
                               <span