fix(react): remove unnecessary title for icon description (#11490)

* fix(react): remove unnecessary title for icon description * fix(react): update snapshots Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
carbon-design-system · May 31, 2022 · 1f1b70a · 1f1b70a
1 parent 2c2d0a0
commit 1f1b70a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
@@ -2501,9 +2501,6 @@ exports[`DataTable should render 1`] = `
                             <path
                               d="M8,11c-1.7,0-3-1.3-3-3s1.3-3,3-3s3,1.3,3,3C11,9.6,9.7,11,8,11C8,11,8,11,8,11z M8,6C6.9,6,6,6.8,6,7.9C6,7.9,6,8,6,8 c0,1.1,0.8,2,1.9,2c0,0,0.1,0,0.1,0c1.1,0,2-0.8,2-1.9c0,0,0-0.1,0-0.1C10,6.9,9.2,6,8,6C8.1,6,8,6,8,6z"
                             />
-                            <title>
-                              Settings
-                            </title>
                           </svg>
                         </Icon>
                       </ForwardRef(Settings)>
@@ -3522,9 +3519,6 @@ exports[`DataTable sticky header should render 1`] = `
                             <path
                               d="M8,11c-1.7,0-3-1.3-3-3s1.3-3,3-3s3,1.3,3,3C11,9.6,9.7,11,8,11C8,11,8,11,8,11z M8,6C6.9,6,6,6.8,6,7.9C6,7.9,6,8,6,8 c0,1.1,0.8,2,1.9,2c0,0,0.1,0,0.1,0c1.1,0,2-0.8,2-1.9c0,0,0-0.1,0-0.1C10,6.9,9.2,6,8,6C8.1,6,8,6,8,6z"
                             />
-                            <title>
-                              Settings
-                            </title>
                           </svg>
                         </Icon>
                       </ForwardRef(Settings)>

diff --git a/...ages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap b/...ages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarMenu-test.js.snap
@@ -85,9 +85,6 @@ exports[`DataTable.TableToolbarMenu should render 1`] = `
               <path
                 d="M13 7L12.3 6.3 8.5 10.1 8.5 1 7.5 1 7.5 10.1 3.7 6.3 3 7 8 12zM13 12v2H3v-2H2v2l0 0c0 .6.4 1 1 1h10c.6 0 1-.4 1-1l0 0v-2H13z"
               />
-              <title>
-                Add
-              </title>
             </svg>
           </Icon>
         </ForwardRef(Download)>

diff --git a/packages/react/src/components/OverflowMenu/OverflowMenu.js b/packages/react/src/components/OverflowMenu/OverflowMenu.js
@@ -569,9 +569,7 @@ class OverflowMenu extends Component {
           aria-label={ariaLabel}
           id={id}
           ref={mergeRefs(this._triggerRef, ref)}>
-          <IconElement {...iconProps}>
-            {iconDescription && <title>{iconDescription}</title>}
-          </IconElement>
+          <IconElement {...iconProps} />
           {open && wrappedMenuBody}
         </button>
       </ClickListener>
-Original file line number
+Diff line change
@@ Expand Up / @@ -85,9 +85,6 @@ exports[`DataTable.TableToolbarMenu should render 1`] = ` @@
                   <path
                     d="M13 7L12.3 6.3 8.5 10.1 8.5 1 7.5 1 7.5 10.1 3.7 6.3 3 7 8 12zM13 12v2H3v-2H2v2l0 0c0 .6.4 1 1 1h10c.6 0 1-.4 1-1l0 0v-2H13z"
                   />
-                  <title>
-                    Add
-                  </title>
                 </svg>
               </Icon>
             </ForwardRef(Download)>
@@ Expand Down @@