fix(list-box): remove role from listbox

carbon-design-system · Jan 9, 2020 · 194f9fa · 194f9fa
1 parent 67439c8
commit 194f9fa
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/packages/react/src/components/ListBox/ListBox.js b/packages/react/src/components/ListBox/ListBox.js
@@ -54,8 +54,6 @@ const ListBox = ({
     <>
       <div
         {...rest}
-        role="listbox"
-        tabIndex="-1"
         className={className}
         ref={innerRef}
         onKeyDown={handleOnKeyDown}

diff --git a/packages/react/src/components/ListBox/ListBoxMenu.js b/packages/react/src/components/ListBox/ListBoxMenu.js
@@ -18,15 +18,18 @@ const { prefix } = settings;
  * class into a single component. It is also being used to validate given
  * `children` components.
  */
-const ListBoxMenu = ({ children, id, ...rest }) => (
-  <div
-    id={`${id}__menu`}
-    className={`${prefix}--list-box__menu`}
-    role="listbox"
-    {...rest}>
-    {children}
-  </div>
-);
+const ListBoxMenu = ({ children, id, ...rest }) => {
+  console.log(rest);
+  return (
+    <div
+      id={`${id}__menu`}
+      className={`${prefix}--list-box__menu`}
+      role="listbox"
+      {...rest}>
+      {children}
+    </div>
+  );
+};
 
 ListBoxMenu.propTypes = {
   /**