Icon lib action bar #906
Merged
Icon lib action bar #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpicone
requested review from
a team,
sstrubberg and
jnm2377
and removed request for
a team
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/carbon-design-system/carbon-website/m7wi0gsdz |
|
it's looking good! my only comment is that there's a small hover/scroll bug. if you're scrolling and your mouse is on one of the icon cards, sometimes the icon buttons still appear over the dropdown menus. |
|
not sure how much of a blocker that is. but otherwise, the copy functionality and everything else work fine. |
|
@jnm2377 great catch ty! Should be good to go. |
jeanservaas
approved these changes
Feb 14, 2020
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
* feat: add icon action bar, begin consolidation into plugin * fix: move to bottom right * feat: filter if iconmetadata includes deprecated=true * fix: add pictogram support * fix: hide dl in idl * feat: add library provider and ability to toggle between sites/library types * fix: use gatsby's reach-router * fix: undo location stuff * fix: z indeces * fix: add prefix * feat: prepare for packagization of svg libs * chore: upgrade change-case
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
* feat: add icon action bar, begin consolidation into plugin * fix: move to bottom right * feat: filter if iconmetadata includes deprecated=true * fix: add pictogram support * fix: hide dl in idl * feat: add library provider and ability to toggle between sites/library types * fix: use gatsby's reach-router * fix: undo location stuff * fix: z indeces * fix: add prefix * feat: prepare for packagization of svg libs * chore: upgrade change-case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #766
closes #395
closes #649
closes #905
Includes set up to filter deprecated icons when carbon add's this feature: carbon-design-system/carbon#5338
TODO: