-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility changes #2737
Accessibility changes #2737
Conversation
Added 5 images and all new content to the Accessibility tab for code snippet. Removed the Screen Reader testing material from the Usage page, and made one minor editorial that seemed acceptable during the playback.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/xDwrek2g8CenLeCZxYQp7Tu395fk |
DCO Assistant Lite bot All contributors have signed the DCO. |
@mbgower Thanks for tackling this! This is great. The next steps are for the design team to provide some feedback or do the design detailing on them illustrations and they need to span 8-columns in the page layout. Can you connect with @aagonzales to see who can support you on these improvements. Much thanks. |
thanks @mjabbink I thought I'd try this way to see if we could accelerate the changes. Here's what I'm doing this time (tracked in our internal system):
|
updated to 8 column
uploaded higher resolution images
added link to accessibility tab
repositioned link to accessibility tab
I have read the DCO document and I hereby sign the DCO. |
Added spacing an asterisks to fix bullets
recheck |
All accessibility tab illustrations updated by Lauren as per discussion with DPO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I see the revised images! ✅
- Question: For any time we reference a keyboard function like
Space
,Enter
,Tab
, etc should we style them as code in markdown like we do on the Usage tab for the Interactions section for consistency? We typically do this for all components. - Also I understand that the word "Labelling" is technically correct and is the preferred spelling in the UK, while "Labeling" is the preferred spelling in the US. Not sure if it matters from a content perspective but wanted to note it here.
I will update the keys to make them like code. |
proof reading fixes: style on keys; spelling of labeling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🎉
Seeing this now brings up wether mixing the two type of beginning and endings together. I did not think of that yesterday. I have a solution below that would allow (at least in this case) to maintain that little vertical straight segment and the beginning/ending of the large arch. It requires some shifting to the right on the code snip and reducing the largest arch down. |
@mjabbink Thanks Mike, I will change this in the next iteration of Code snippet. 👍 |
Not sure if the little straight segment is going to be a major pain all the time or only on occasion. Otherwise maybe the purple half circle might be better (as long as arrows are vertical or horizontal). |
@mjabbink All great things to chew on. With a long horizontal target, there is more flexibility here than on some other components. As Lauren says, if we keep that in mind for other components we're updating images for, we can go back and choose which one seems to work better for other components |
@mbgower I recommend adding the “why” or “benefit”. I feel like if we say statement like this then we should follow up with why we do it or the benefit to the users. Current Suggestion |
Added 5 images and all new content to the Accessibility tab for code snippet.
Removed the Screen Reader testing material from the Usage page, and made one minor editorial that seemed acceptable during the playback.
Closes #
{{short description}}
Changelog
New
Changed
Removed