Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): close tooltip on escape or focusout #9871

Merged
merged 6 commits into from
Jan 11, 2023
Merged

fix(tooltip): close tooltip on escape or focusout #9871

merged 6 commits into from
Jan 11, 2023

Conversation

andy-blum
Copy link
Contributor

Related Ticket(s)

Fixes #8996

Description

Adds Escape logic to the keydown listener and a new focusout listener. Both will toggle the state of the tooltip only in the "closed" direction

Changelog

Changed

  • Accessibility improvements to tooltip

@andy-blum andy-blum requested a review from a team as a code owner December 29, 2022 19:21
@andy-blum andy-blum added bug Something isn't working severity 4 Affects minor functionality, no workaround needed accessibility Has accessibility requirement package: carbon web components owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants labels Dec 29, 2022
@annawen1 annawen1 closed this Jan 3, 2023
@annawen1 annawen1 reopened this Jan 3, 2023
kennylam
kennylam approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @andy-blum!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9871/index.html

Built with commit: 8eb93698f11cd793a916430d670a3105efa57acd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9871/index.html

Built with commit: 8eb93698f11cd793a916430d670a3105efa57acd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9871/index.html

Built with commit: 8eb93698f11cd793a916430d670a3105efa57acd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9871/index.html

Built with commit: 8eb93698f11cd793a916430d670a3105efa57acd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2023 •
edited
Loading

Deploy preview created for package "Carbon Web Components":
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9871/index.html

Built with commit: 8eb93698f11cd793a916430d670a3105efa57acd

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 3, 2023
@kodiakhq kodiakhq bot merged commit 3fdd70e into carbon-design-system:main Jan 11, 2023
@andy-blum andy-blum deleted the fix/tooltip-a11y branch February 20, 2023 14:36
@annawen1 annawen1 mentioned this pull request Mar 9, 2023
Merged
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@andy-blum
fix(tooltip): close tooltip on escape or focusout (carbon-design-syst…
fbea430 
…em#9871)

### Related Ticket(s)

Fixes carbon-design-system#8996 

### Description

Adds `Escape` logic to the `keydown` listener and a new `focusout` listener. Both will toggle the state of the tooltip only in the "closed" direction

### Changelog

**Changed**

- Accessibility improvements to tooltip
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@andy-blum
fix(tooltip): close tooltip on escape or focusout (carbon-design-syst…
4759855 
…em#9871)

### Related Ticket(s)

Fixes carbon-design-system#8996 

### Description

Adds `Escape` logic to the `keydown` listener and a new `focusout` listener. Both will toggle the state of the tooltip only in the "closed" direction

### Changelog

**Changed**

- Accessibility improvements to tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
accessibility Has accessibility requirement bug Something isn't working owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: carbon web components Ready to merge Label for the pull requests that are ready to merge severity 4 Affects minor functionality, no workaround needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Background Media]: QA: Tooltip of the play button is not getting dismissed with esc key.
4 participants
@andy-blum @ibmdotcom-bot @kennylam @annawen1