Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pagination): fix issues with pagination playground story #10883

Merged
merged 3 commits into from
Aug 30, 2023
Merged

fix(pagination): fix issues with pagination playground story #10883

merged 3 commits into from
Aug 30, 2023

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Aug 25, 2023 •
edited
Loading

Related Ticket(s)

Closes #10882
https://jsw.ibm.com/browse/ADCMS-3821

Description

Fixes issues with two of the knobs on the Pagination > Playground story.

Changelog

Changed

  • Updated Pagination > Playground story to allow testing page-size and items-per-page-text attributes of <cds-pagination> component.

Testing Instructions

  • Open Carbon Web Components Storybook
  • Navigate to Pagination > Playground
  • Change values for "Items per page text" and "Number of rows per page (page-size)" knobs
  • You should see the changes reflected in the rendered output

@m4olivei m4olivei requested a review from a team as a code owner August 25, 2023 17:52
@m4olivei m4olivei requested review from kennylam and annawen1 August 25, 2023 17:52
@m4olivei m4olivei mentioned this pull request Aug 25, 2023
Closed
2 tasks
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10883/index.html

Built with commit: 96c42eae4a90e49b5371ac9694b0cecdaa988578

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10883/index.html

Built with commit: 96c42eae4a90e49b5371ac9694b0cecdaa988578

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10883/index.html

Built with commit: 96c42eae4a90e49b5371ac9694b0cecdaa988578

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10883/index.html

Built with commit: 96c42eae4a90e49b5371ac9694b0cecdaa988578

@m4olivei m4olivei requested a review from andy-blum August 25, 2023 18:58
@annawen1 annawen1 linked an issue Aug 28, 2023 that may be closed by this pull request
[Pagination]: Bugs with Pagination > Playground story make it hard to test certain use cases #10882
Closed
2 tasks
IgnacioBecerra
IgnacioBecerra approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @m4olivei!

@m4olivei m4olivei added Ready to merge Label for the pull requests that are ready to merge and removed 👀 eyes needed labels Aug 30, 2023
@m4olivei
Copy link
Contributor Author

m4olivei commented Aug 30, 2023 •
edited
Loading

Thanks @IgnacioBecerra

I've added the Ready to merge label. Although there are required job failures, none of them are things that I recognize or feel like would relate to changes here. Noticing that the feature branch has similar job failures. Do you see a specific job that needs to be resolved here? If not could you do the merge? Thanks.

jkaeser
jkaeser approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@jkaeser jkaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me! The Story works as described in the testing instructions.

@IgnacioBecerra IgnacioBecerra merged commit 082b467 into carbon-design-system:feat/cwc-v2 Aug 30, 2023
@m4olivei m4olivei deleted the fix/pagination-story branch August 31, 2023 13:02
@m4olivei m4olivei mentioned this pull request Aug 31, 2023
Closed
2 tasks
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@m4olivei
fix(pagination): fix issues with pagination playground story (carbon-…
2b83603 
…design-system#10883)

* fix(pagination): fix issues with pagination playground story

* fix(pagination): avoid division by 0
@m4olivei m4olivei restored the fix/pagination-story branch February 26, 2024 21:54
@m4olivei m4olivei deleted the fix/pagination-story branch February 26, 2024 21:56
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@m4olivei
fix(pagination): fix issues with pagination playground story (carbon-…
1e5d24f 
…design-system#10883)

* fix(pagination): fix issues with pagination playground story

* fix(pagination): avoid division by 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaeser jkaeser jkaeser approved these changes

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees
No one assigned
Labels
bug Something isn't working package: carbon web components Ready to merge Label for the pull requests that are ready to merge v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pagination]: Bugs with Pagination > Playground story make it hard to test certain use cases
4 participants
@m4olivei @ibmdotcom-bot @jkaeser @IgnacioBecerra